refactor(quality): Q14 前端巨型组件拆分 — ServerManager 652L→442L (-32%), 提取 ServerTableSection (265L, 表格+工具栏+分页受控展示组件) + server-export-utils (57L, CSV 导出纯函数), 移除 12 个不再使用的 import, 零逻辑变更

This commit is contained in:
attacker committed 2026-07-07 22:38:49 +08:00
1 parent 8a11acd086
commit 02f3d75f56
6 files changed
+441 -244

No files matched your search

+33 -243
View File
@@ -2,8 +2,6 @@ import { useState, useMemo } from "react";
import { useTranslation } from "react-i18next";
import { cn } from "@/lib/utils";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import { Checkbox } from "@/components/ui/checkbox";
import {
DropdownMenu,
DropdownMenuContent,
@@ -13,31 +11,12 @@ import {
DropdownMenuTrigger,
} from "@/components/ui/dropdown-menu";
import {
Table,
TableBody,
TableCell,
TableHead,
TableHeader,
TableRow,
} from "@/components/ui/table";
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from "@/components/ui/select";
import {
Search,
Plus,
Trash2,
Download,
Upload,
Cloud,
FileSpreadsheet,
RefreshCw,
ChevronLeft,
ChevronRight,
} from "lucide-react";
import { useServers, useServerMutations } from "@/hooks/api";
import { ServerStatsStrip } from "./ServerStatsStrip";
@@ -50,11 +29,10 @@ import { ServerFileBrowser } from "./ServerFileBrowser";
import type { JsonData } from "@/types/common";
import { ExcelServerImport } from "./ExcelServerImport";
import { ServerForm, EMPTY_FORM, type ServerFormData } from "./ServerForm";
import { getTags } from "./serverHelpers";
import { ServerTableRow } from "./ServerTableRow";
import { ServerTableSection } from "./ServerTableSection";
import { buildServersCsv, downloadCsv } from "./server-export-utils";
import { usePermission } from "@/hooks/usePermission";
import { PageShell } from "@/components/layout/PageShell";
import { ContentPanel } from "@/components/layout/ContentPanel";
import { Server } from "lucide-react";
export function ServerManager() {
@@ -152,7 +130,6 @@ export function ServerManager() {
setPage(1);
};
// 导出 CSV
const toggleSelectAll = () => {
if (selectedServers.length === servers.length) {
setSelectedServers([]);
@@ -305,101 +282,14 @@ export function ServerManager() {
toast.error(t("server.noExportData"));
return;
}
const headers = [
t("server.csv.hostname"),
t("server.csv.ip"),
t("server.csv.publicIp"),
t("server.csv.port"),
t("server.csv.os"),
t("server.csv.cpu"),
t("server.csv.memory"),
t("server.csv.disk"),
t("server.csv.status"),
t("server.csv.tags"),
];
const rows = servers.map((s) => {
const memGB = s.memory ? Math.round(Number(s.memory) / 1024) : 0;
const tags = getTags(s).join(";");
return [
s.hostname || "",
s.ip || "",
s.public_ip || "",
s.port || 22,
s.os || "",
s.cpu || 0,
memGB,
s.disk || 0,
s.status || "",
tags,
];
});
const csv = [headers, ...rows]
.map((row) =>
row.map((cell) => `"${String(cell).replace(/"/g, '""')}"`).join(","),
)
.join("\n");
const blob = new Blob(["\ufeff" + csv], {
type: "text/csv;charset=utf-8;",
});
const url = URL.createObjectURL(blob);
const a = document.createElement("a");
a.href = url;
a.download = `servers_${new Date().toISOString().slice(0, 10)}.csv`;
a.click();
URL.revokeObjectURL(url);
const csv = buildServersCsv(servers, t);
downloadCsv(
`servers_${new Date().toISOString().slice(0, 10)}.csv`,
csv,
);
toast.success(t("server.exported", { count: servers.length }));
};
const colSpanCount = 8;
const tableToolbar = (
<>
<div className="flex items-center gap-3 flex-wrap">
<div className="relative w-64">
<Search className="absolute left-3 top-1/2 -translate-y-1/2 h-4 w-4 dg-text-muted" />
<Input
placeholder={t("server.searchPlaceholder")}
value={searchQuery}
onChange={(e) => handleSearch(e.target.value)}
className="pl-9 h-9 dg-input"
/>
</div>
<Select value={statusFilter} onValueChange={handleStatusFilter}>
<SelectTrigger className="w-32 h-9 dg-input">
<SelectValue placeholder={t("common.status")} />
</SelectTrigger>
<SelectContent>
<SelectItem value="all">{t("server.allStatus")}</SelectItem>
<SelectItem value="running">{t("common.running")}</SelectItem>
<SelectItem value="stopped">{t("common.stopped")}</SelectItem>
<SelectItem value="maintenance">
{t("common.maintenance")}
</SelectItem>
<SelectItem value="offline">{t("common.offline")}</SelectItem>
</SelectContent>
</Select>
</div>
{selectedServers.length > 0 && (
<div className="flex items-center gap-2">
<span className="text-sm dg-text-secondary">
{t("server.selected", { count: selectedServers.length })}
</span>
{hasPermission("server:delete") && (
<Button
variant="outline"
size="sm"
className="dg-btn-danger dg-btn-sm"
onClick={handleBatchDelete}
>
<Trash2 className="h-4 w-4 mr-2" />
{t("server.batchDelete")}
</Button>
)}
</div>
)}
</>
);
return (
<PageShell
variant="list"
@@ -467,132 +357,32 @@ export function ServerManager() {
</>
}
>
<ContentPanel toolbar={tableToolbar}>
<div>
<Table>
<TableHeader>
<TableRow className="border-[var(--dg-border)] hover:bg-transparent">
<TableHead className="w-12">
<Checkbox
checked={
selectedServers.length === servers.length &&
servers.length > 0
}
onCheckedChange={toggleSelectAll}
/>
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.hostname")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.ipAddress")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.publicIp")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("common.status")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.config")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.tags")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)] text-right">
{t("common.actions")}
</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{loading ? (
<TableRow className="border-[var(--dg-border)]">
<TableCell
colSpan={colSpanCount}
className="text-center text-[var(--dg-text-muted)] py-12"
>
<RefreshCw className="h-5 w-5 animate-spin mx-auto mb-2" />
{t("common.loading")}
</TableCell>
</TableRow>
) : servers.length === 0 ? (
<TableRow className="border-[var(--dg-border)]">
<TableCell
colSpan={colSpanCount}
className="text-center text-[var(--dg-text-muted)] py-12"
>
{t("server.noData")}
</TableCell>
</TableRow>
) : (
servers.map((server) => (
<ServerTableRow
key={server.id}
server={server}
selected={selectedServers.includes(String(server.id))}
onToggleSelect={toggleSelect}
onOpenTerminal={openTerminal}
onOpenRdp={openRdp}
onOpenFiles={openFileBrowser}
onOpenEdit={openEditForm}
onDelete={handleDelete}
/>
))
)}
</TableBody>
</Table>
</div>
{/* 分页 */}
<div className="flex items-center justify-between px-4 py-3 border-t border-[var(--dg-border)]">
<div className="flex items-center gap-2 text-sm text-[var(--dg-text-muted)]">
<span>{t("server.perPage")}</span>
<Select
value={String(pageSize)}
onValueChange={(v) => {
setPageSize(Number(v));
setPage(1);
}}
>
<SelectTrigger className="w-16 h-8 bg-[var(--dg-bg-tertiary)] border-[var(--dg-border)] text-[var(--dg-text-primary)] text-xs">
<SelectValue />
</SelectTrigger>
<SelectContent className="bg-[var(--dg-bg-tertiary)] border-[var(--dg-border)]">
<SelectItem value="10">10</SelectItem>
<SelectItem value="20">20</SelectItem>
<SelectItem value="30">30</SelectItem>
</SelectContent>
</Select>
<span>{t("server.items")}</span>
<span className="ml-4">
{t("server.totalItems", { count: total })}
</span>
</div>
<div className="flex items-center gap-1">
<Button
variant="outline"
size="sm"
className="h-8 border-[var(--dg-border)] text-[var(--dg-text-secondary)] hover:text-[var(--dg-text-primary)] hover:bg-[var(--dg-bg-hover)]"
disabled={page <= 1}
onClick={() => setPage((p) => Math.max(1, p - 1))}
>
<ChevronLeft className="h-4 w-4" />
</Button>
<span className="text-sm text-[var(--dg-text-secondary)] px-2">
{page} / {Math.max(1, Math.ceil(total / pageSize))}
</span>
<Button
variant="outline"
size="sm"
className="h-8 border-[var(--dg-border)] text-[var(--dg-text-secondary)] hover:text-[var(--dg-text-primary)] hover:bg-[var(--dg-bg-hover)]"
disabled={page >= Math.ceil(total / pageSize)}
onClick={() => setPage((p) => p + 1)}
>
<ChevronRight className="h-4 w-4" />
</Button>
</div>
</div>
</ContentPanel>
<ServerTableSection
servers={servers}
loading={loading}
total={total}
page={page}
pageSize={pageSize}
onPageChange={setPage}
onPageSizeChange={(size) => {
setPageSize(size);
setPage(1);
}}
searchQuery={searchQuery}
statusFilter={statusFilter}
onSearchChange={handleSearch}
onStatusFilterChange={handleStatusFilter}
selectedServers={selectedServers}
onToggleSelectAll={toggleSelectAll}
onToggleSelect={toggleSelect}
onBatchDelete={handleBatchDelete}
canDelete={hasPermission("server:delete")}
onOpenTerminal={openTerminal}
onOpenRdp={openRdp}
onOpenFiles={openFileBrowser}
onOpenEdit={openEditForm}
onDelete={handleDelete}
/>
{/* 创建/编辑服务器 Dialog */}
<ServerForm
@@ -0,0 +1,265 @@
import { useTranslation } from "react-i18next";
import { cn } from "@/lib/utils";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import { Checkbox } from "@/components/ui/checkbox";
import {
Table,
TableBody,
TableCell,
TableHead,
TableHeader,
TableRow,
} from "@/components/ui/table";
import {
Select,
SelectContent,
SelectItem,
SelectTrigger,
SelectValue,
} from "@/components/ui/select";
import {
Search,
Trash2,
RefreshCw,
ChevronLeft,
ChevronRight,
} from "lucide-react";
import { ContentPanel } from "@/components/layout/ContentPanel";
import { ServerTableRow } from "./ServerTableRow";
import type { JsonData } from "@/types/common";
export interface ServerTableSectionProps {
/** 服务器列表数据 */
servers: JsonData[];
/** 加载中 */
loading: boolean;
/** 总数 */
total: number;
/** 分页 */
page: number;
pageSize: number;
onPageChange: (page: number) => void;
onPageSizeChange: (size: number) => void;
/** 搜索/筛选 */
searchQuery: string;
statusFilter: string;
onSearchChange: (val: string) => void;
onStatusFilterChange: (val: string) => void;
/** 选择 */
selectedServers: string[];
onToggleSelectAll: () => void;
onToggleSelect: (id: string) => void;
onBatchDelete: () => void;
canDelete: boolean;
/** 行操作回调 */
onOpenTerminal: (server: JsonData) => void;
onOpenRdp: (server: JsonData) => void;
onOpenFiles: (server: JsonData) => void;
onOpenEdit: (server: JsonData) => void;
onDelete: (id: string) => void;
}
const COL_SPAN = 8;
export function ServerTableSection({
servers,
loading,
total,
page,
pageSize,
onPageChange,
onPageSizeChange,
searchQuery,
statusFilter,
onSearchChange,
onStatusFilterChange,
selectedServers,
onToggleSelectAll,
onToggleSelect,
onBatchDelete,
canDelete,
onOpenTerminal,
onOpenRdp,
onOpenFiles,
onOpenEdit,
onDelete,
}: ServerTableSectionProps) {
const { t } = useTranslation();
const tableToolbar = (
<>
<div className="flex items-center gap-3 flex-wrap">
<div className="relative w-64">
<Search className="absolute left-3 top-1/2 -translate-y-1/2 h-4 w-4 dg-text-muted" />
<Input
placeholder={t("server.searchPlaceholder")}
value={searchQuery}
onChange={(e) => onSearchChange(e.target.value)}
className="pl-9 h-9 dg-input"
/>
</div>
<Select value={statusFilter} onValueChange={onStatusFilterChange}>
<SelectTrigger className="w-32 h-9 dg-input">
<SelectValue placeholder={t("common.status")} />
</SelectTrigger>
<SelectContent>
<SelectItem value="all">{t("server.allStatus")}</SelectItem>
<SelectItem value="running">{t("common.running")}</SelectItem>
<SelectItem value="stopped">{t("common.stopped")}</SelectItem>
<SelectItem value="maintenance">
{t("common.maintenance")}
</SelectItem>
<SelectItem value="offline">{t("common.offline")}</SelectItem>
</SelectContent>
</Select>
</div>
{selectedServers.length > 0 && (
<div className="flex items-center gap-2">
<span className="text-sm dg-text-secondary">
{t("server.selected", { count: selectedServers.length })}
</span>
{canDelete && (
<Button
variant="outline"
size="sm"
className="dg-btn-danger dg-btn-sm"
onClick={onBatchDelete}
>
<Trash2 className="h-4 w-4 mr-2" />
{t("server.batchDelete")}
</Button>
)}
</div>
)}
</>
);
const totalPages = Math.max(1, Math.ceil(total / pageSize));
return (
<ContentPanel toolbar={tableToolbar}>
<div>
<Table>
<TableHeader>
<TableRow className="border-[var(--dg-border)] hover:bg-transparent">
<TableHead className="w-12">
<Checkbox
checked={
selectedServers.length === servers.length &&
servers.length > 0
}
onCheckedChange={onToggleSelectAll}
/>
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.hostname")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.ipAddress")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.publicIp")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("common.status")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.config")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)]">
{t("server.tags")}
</TableHead>
<TableHead className="text-[var(--dg-text-secondary)] text-right">
{t("common.actions")}
</TableHead>
</TableRow>
</TableHeader>
<TableBody>
{loading ? (
<TableRow className="border-[var(--dg-border)]">
<TableCell
colSpan={COL_SPAN}
className="text-center text-[var(--dg-text-muted)] py-12"
>
<RefreshCw className="h-5 w-5 animate-spin mx-auto mb-2" />
{t("common.loading")}
</TableCell>
</TableRow>
) : servers.length === 0 ? (
<TableRow className="border-[var(--dg-border)]">
<TableCell
colSpan={COL_SPAN}
className="text-center text-[var(--dg-text-muted)] py-12"
>
{t("server.noData")}
</TableCell>
</TableRow>
) : (
servers.map((server) => (
<ServerTableRow
key={server.id}
server={server}
selected={selectedServers.includes(String(server.id))}
onToggleSelect={onToggleSelect}
onOpenTerminal={onOpenTerminal}
onOpenRdp={onOpenRdp}
onOpenFiles={onOpenFiles}
onOpenEdit={onOpenEdit}
onDelete={onDelete}
/>
))
)}
</TableBody>
</Table>
</div>
{/* 分页 */}
<div className="flex items-center justify-between px-4 py-3 border-t border-[var(--dg-border)]">
<div className="flex items-center gap-2 text-sm text-[var(--dg-text-muted)]">
<span>{t("server.perPage")}</span>
<Select
value={String(pageSize)}
onValueChange={(v) => onPageSizeChange(Number(v))}
>
<SelectTrigger className="w-16 h-8 bg-[var(--dg-bg-tertiary)] border-[var(--dg-border)] text-[var(--dg-text-primary)] text-xs">
<SelectValue />
</SelectTrigger>
<SelectContent className="bg-[var(--dg-bg-tertiary)] border-[var(--dg-border)]">
<SelectItem value="10">10</SelectItem>
<SelectItem value="20">20</SelectItem>
<SelectItem value="30">30</SelectItem>
</SelectContent>
</Select>
<span>{t("server.items")}</span>
<span className="ml-4">
{t("server.totalItems", { count: total })}
</span>
</div>
<div className="flex items-center gap-1">
<Button
variant="outline"
size="sm"
className="h-8 border-[var(--dg-border)] text-[var(--dg-text-secondary)] hover:text-[var(--dg-text-primary)] hover:bg-[var(--dg-bg-hover)]"
disabled={page <= 1}
onClick={() => onPageChange(Math.max(1, page - 1))}
>
<ChevronLeft className="h-4 w-4" />
</Button>
<span className="text-sm text-[var(--dg-text-secondary)] px-2">
{page} / {totalPages}
</span>
<Button
variant="outline"
size="sm"
className="h-8 border-[var(--dg-border)] text-[var(--dg-text-secondary)] hover:text-[var(--dg-text-primary)] hover:bg-[var(--dg-bg-hover)]"
disabled={page >= totalPages}
onClick={() => onPageChange(page + 1)}
>
<ChevronRight className={cn("h-4 w-4")} />
</Button>
</div>
</div>
</ContentPanel>
);
}
@@ -0,0 +1,57 @@
import type { TFunction } from "i18next";
import type { JsonData } from "@/types/common";
import { getTags } from "./serverHelpers";
/**
* 将服务器列表构建为 CSV 字符串(含 UTF-8 BOM)。
* 纯函数,无副作用 — 调用方负责触发下载。
*/
export function buildServersCsv(servers: JsonData[], t: TFunction): string {
const headers = [
t("server.csv.hostname"),
t("server.csv.ip"),
t("server.csv.publicIp"),
t("server.csv.port"),
t("server.csv.os"),
t("server.csv.cpu"),
t("server.csv.memory"),
t("server.csv.disk"),
t("server.csv.status"),
t("server.csv.tags"),
];
const rows = servers.map((s) => {
const memGB = s.memory ? Math.round(Number(s.memory) / 1024) : 0;
const tags = getTags(s).join(";");
return [
s.hostname || "",
s.ip || "",
s.public_ip || "",
s.port || 22,
s.os || "",
s.cpu || 0,
memGB,
s.disk || 0,
s.status || "",
tags,
];
});
const csv = [headers, ...rows]
.map((row) =>
row.map((cell) => `"${String(cell).replace(/"/g, '""')}"`).join(","),
)
.join("\n");
return "\ufeff" + csv;
}
/**
* 触发浏览器下载 CSV 文件。
*/
export function downloadCsv(filename: string, content: string): void {
const blob = new Blob([content], { type: "text/csv;charset=utf-8;" });
const url = URL.createObjectURL(blob);
const a = document.createElement("a");
a.href = url;
a.download = filename;
a.click();
URL.revokeObjectURL(url);
}