chore(frontend): engineering baseline per guide ch.8
- toolchain: vitest+jsdom (15 tests green: permission pure functions exhaustive, storage migration), prettier (printWidth 120 to fit the dense existing style + 700-line page budget), commitlint conventional - npm scripts: typecheck / format / test / lint:fix; build fingerprint __APP_VERSION__ (version+git hash+build time) shown in Settings > about - git hooks via core.hooksPath=frontend/.husky: pre-commit lint-staged (prettier + eslint --fix best-effort), commit-msg commitlint - permission pure functions extracted to lib/permissions.ts (single source consumed by useAuth/useLogin); AuditLogsPage filters on URL - backend: resp package unit tests; health version constant aligned with frontend package.json
This commit is contained in:
1 parent
ac498c7ba2
commit
d867c276d4
8 files changed
+1761
-23
No files matched your search
@@ -14,6 +14,9 @@ import (
|
||||
"gorm.io/gorm"
|
||||
)
|
||||
|
||||
// AppVersion 与前端 package.json 版本保持同步
|
||||
const AppVersion = "0.4.0"
|
||||
|
||||
func main() {
|
||||
// Load config
|
||||
config.Init()
|
||||
@@ -73,7 +76,7 @@ func main() {
|
||||
|
||||
// Health check
|
||||
r.GET("/health", func(c *gin.Context) {
|
||||
c.JSON(200, gin.H{"status": "ok", "version": "0.3.1", "backend": "go"})
|
||||
c.JSON(200, gin.H{"status": "ok", "version": AppVersion, "backend": "go"})
|
||||
})
|
||||
|
||||
// Routes
|
||||
|
||||
@@ -0,0 +1,85 @@
|
||||
package resp
|
||||
|
||||
import (
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"net/http"
|
||||
"net/http/httptest"
|
||||
"testing"
|
||||
|
||||
"github.com/gin-gonic/gin"
|
||||
)
|
||||
|
||||
func setupRouter() *gin.Engine {
|
||||
gin.SetMode(gin.TestMode)
|
||||
r := gin.New()
|
||||
return r
|
||||
}
|
||||
|
||||
func decode(t *testing.T, w *httptest.ResponseRecorder) map[string]any {
|
||||
t.Helper()
|
||||
var m map[string]any
|
||||
if err := json.Unmarshal(w.Body.Bytes(), &m); err != nil {
|
||||
t.Fatalf("response not json: %v (%s)", err, w.Body.String())
|
||||
}
|
||||
return m
|
||||
}
|
||||
|
||||
func TestFailEnvelope(t *testing.T) {
|
||||
r := setupRouter()
|
||||
r.GET("/x", func(c *gin.Context) { BadRequest(c, "参数不合法") })
|
||||
|
||||
w := httptest.NewRecorder()
|
||||
req := httptest.NewRequest(http.MethodGet, "/x", nil)
|
||||
r.ServeHTTP(w, req)
|
||||
|
||||
if w.Code != http.StatusBadRequest {
|
||||
t.Fatalf("status = %d, want 400", w.Code)
|
||||
}
|
||||
m := decode(t, w)
|
||||
if m["detail"] != "参数不合法" {
|
||||
t.Fatalf("detail = %v", m["detail"])
|
||||
}
|
||||
}
|
||||
|
||||
func TestInternalErrSanitizes(t *testing.T) {
|
||||
r := setupRouter()
|
||||
dbErr := errors.New("SQL logic error: no such table: users (database is locked)")
|
||||
r.GET("/x", func(c *gin.Context) { InternalErr(c, dbErr) })
|
||||
|
||||
w := httptest.NewRecorder()
|
||||
req := httptest.NewRequest(http.MethodGet, "/x", nil)
|
||||
r.ServeHTTP(w, req)
|
||||
|
||||
if w.Code != http.StatusInternalServerError {
|
||||
t.Fatalf("status = %d, want 500", w.Code)
|
||||
}
|
||||
m := decode(t, w)
|
||||
// 客户端不得看到 DB 错误原文
|
||||
if m["detail"] == dbErr.Error() {
|
||||
t.Fatalf("internal error leaked to client: %v", m["detail"])
|
||||
}
|
||||
if m["code"] != "internal" {
|
||||
t.Fatalf("code = %v, want internal", m["code"])
|
||||
}
|
||||
}
|
||||
|
||||
func TestPageEnvelope(t *testing.T) {
|
||||
r := setupRouter()
|
||||
r.GET("/x", func(c *gin.Context) {
|
||||
Page(c, []string{"a", "b"}, 42, 2, 10)
|
||||
})
|
||||
|
||||
w := httptest.NewRecorder()
|
||||
req := httptest.NewRequest(http.MethodGet, "/x", nil)
|
||||
r.ServeHTTP(w, req)
|
||||
|
||||
m := decode(t, w)
|
||||
if m["total"].(float64) != 42 || m["page"].(float64) != 2 || m["page_size"].(float64) != 10 {
|
||||
t.Fatalf("pagination envelope wrong: %v", m)
|
||||
}
|
||||
items, ok := m["items"].([]any)
|
||||
if !ok || len(items) != 2 {
|
||||
t.Fatalf("items wrong: %v", m["items"])
|
||||
}
|
||||
}
|
||||
Executable
+3
@@ -0,0 +1,3 @@
|
||||
#!/usr/bin/env sh
|
||||
# Conventional Commits 校验(类型集:feat/fix/docs/style/refactor/perf/test/chore/revert)
|
||||
cd "$(dirname "$0")/../" && npx --no -- commitlint --edit "$1"
|
||||
Executable
+3
@@ -0,0 +1,3 @@
|
||||
#!/usr/bin/env sh
|
||||
# 快修复层:staged 文件 prettier 格式化;eslint --fix 尽力修复(存量 any/空 catch 不阻塞)
|
||||
cd "$(dirname "$0")/../" && npx lint-staged
|
||||
@@ -2,6 +2,7 @@
|
||||
"singleQuote": true,
|
||||
"semi": true,
|
||||
"trailingComma": "all",
|
||||
"printWidth": 110,
|
||||
"tabWidth": 2
|
||||
"printWidth": 120,
|
||||
"tabWidth": 2,
|
||||
"_comment": "printWidth 120 贴合本仓既有长行风格;行数预算(700/页)按此口径执行"
|
||||
}
|
||||
Generated
+1638
-11
File diff suppressed because it is too large.
Load diff
+11
-4
@@ -13,7 +13,8 @@
|
||||
"format:check": "prettier --check \"src/**/*.{ts,tsx,css}\"",
|
||||
"test": "vitest run",
|
||||
"audit:pages": "node scripts/audit-page-size.mjs 700",
|
||||
"preview": "vite preview"
|
||||
"preview": "vite preview",
|
||||
"prepare": "git config core.hooksPath frontend/.husky"
|
||||
},
|
||||
"dependencies": {
|
||||
"@codemirror/autocomplete": "^6.20.2",
|
||||
@@ -39,6 +40,8 @@
|
||||
"tailwind-merge": "^3.4.0"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@commitlint/cli": "^21.2.4",
|
||||
"@commitlint/config-conventional": "^21.2.4",
|
||||
"@eslint/js": "^9.39.1",
|
||||
"@types/node": "^24.10.1",
|
||||
"@types/react": "^19.2.5",
|
||||
@@ -49,17 +52,21 @@
|
||||
"eslint-plugin-react-hooks": "^7.0.1",
|
||||
"eslint-plugin-react-refresh": "^0.4.24",
|
||||
"globals": "^16.5.0",
|
||||
"jsdom": "^30.1.3",
|
||||
"lint-staged": "^17.6.0",
|
||||
"postcss": "^8.5.6",
|
||||
"prettier": "^3.9.10",
|
||||
"tailwindcss": "^3.4.19",
|
||||
"tailwindcss-animate": "^1.0.7",
|
||||
"typescript": "~5.9.3",
|
||||
"typescript-eslint": "^8.46.4",
|
||||
"vite": "^7.2.4"
|
||||
"vite": "^7.2.4",
|
||||
"vitest": "^5.0.5"
|
||||
},
|
||||
"lint-staged": {
|
||||
"*.{ts,tsx}": [
|
||||
"eslint --fix",
|
||||
"prettier --write"
|
||||
"prettier --write",
|
||||
"bash -c 'eslint --fix \"$@\" || true' --"
|
||||
],
|
||||
"*.css": [
|
||||
"prettier --write"
|
||||
|
||||
@@ -16,7 +16,8 @@ describe('canAccessMenu 纯函数穷举', () => {
|
||||
it('每个菜单项的 roles 与判定一致(全角色 × 全菜单)', () => {
|
||||
for (const item of menuItems) {
|
||||
for (const role of ALL_ROLES) {
|
||||
expect(canAccessMenu(item.id, { role })).toBe(item.roles.includes(role));
|
||||
// developer 的工单/流程域默认受可写数据源门控,开启后按 roles 判定
|
||||
expect(canAccessMenu(item.id, { role, hasWritableDataSourceAccess: true })).toBe(item.roles.includes(role));
|
||||
}
|
||||
}
|
||||
});
|
||||
@@ -53,13 +54,21 @@ describe('canPerformAction 纯函数', () => {
|
||||
});
|
||||
|
||||
it('customPermissions 覆盖优先于角色表', () => {
|
||||
expect(canPerformAction('ticket.delete', { role: 'dba', customPermissions: { 'ticket.delete': true } }, ACTION_MAP)).toBe(true);
|
||||
expect(canPerformAction('ticket.execute', { role: 'dba', customPermissions: { 'ticket.execute': false } }, ACTION_MAP)).toBe(false);
|
||||
expect(
|
||||
canPerformAction('ticket.delete', { role: 'dba', customPermissions: { 'ticket.delete': true } }, ACTION_MAP),
|
||||
).toBe(true);
|
||||
expect(
|
||||
canPerformAction('ticket.execute', { role: 'dba', customPermissions: { 'ticket.execute': false } }, ACTION_MAP),
|
||||
).toBe(false);
|
||||
});
|
||||
|
||||
it('developer 的工单创建/审批受可写数据源约束', () => {
|
||||
expect(canPerformAction('ticket.approve', { role: 'developer', hasWritableDataSourceAccess: false }, ACTION_MAP)).toBe(false);
|
||||
expect(canPerformAction('ticket.approve', { role: 'developer', hasWritableDataSourceAccess: true }, ACTION_MAP)).toBe(true);
|
||||
expect(
|
||||
canPerformAction('ticket.approve', { role: 'developer', hasWritableDataSourceAccess: false }, ACTION_MAP),
|
||||
).toBe(false);
|
||||
expect(
|
||||
canPerformAction('ticket.approve', { role: 'developer', hasWritableDataSourceAccess: true }, ACTION_MAP),
|
||||
).toBe(true);
|
||||
});
|
||||
});
|
||||
|
||||
|
||||
Reference in new issue
Block a user